Skip to content

Make in_column the first argument in every transform #247

Merged
merged 5 commits into from Nov 2, 2021
Merged

Conversation

alex-hse-repository
Copy link
Collaborator

@alex-hse-repository alex-hse-repository commented Nov 2, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Make in_column the first argument in every transform

Related Issue

Closing issues

closes #215

@alex-hse-repository alex-hse-repository added the enhancement New feature or request label Nov 2, 2021
@alex-hse-repository alex-hse-repository self-assigned this Nov 2, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #247 (7367be5) into master (3853ec3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #247   +/-   ##
=======================================
  Coverage   86.43%   86.43%           
=======================================
  Files          89       89           
  Lines        4240     4240           
=======================================
  Hits         3665     3665           
  Misses        575      575           
Impacted Files Coverage Δ
etna/transforms/scalers.py 100.00% <ø> (ø)
etna/transforms/sklearn.py 95.83% <ø> (ø)
etna/transforms/add_constant.py 100.00% <100.00%> (ø)
etna/transforms/lags.py 100.00% <100.00%> (ø)
etna/transforms/statistics.py 98.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3853ec3...7367be5. Read the comment docs.

@martins0n martins0n requested review from martins0n and Mr-Geekman and removed request for martins0n November 2, 2021 07:44
in_column:
name of processed column

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we delete this space?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No we should't)

@Mr-Geekman Mr-Geekman merged commit b6c43b0 into master Nov 2, 2021
@iKintosh iKintosh deleted the issue-215 branch November 18, 2021 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make in_column the first argument in every transform
3 participants