Skip to content

Enhance HolidayTransform #1340

Merged
merged 12 commits into from
Aug 7, 2023
Merged

Enhance HolidayTransform #1340

merged 12 commits into from
Aug 7, 2023

Conversation

malodetz
Copy link
Collaborator

@malodetz malodetz commented Jul 31, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

See #763

Closing issues

Closes #763

@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2023

Codecov Report

Merging #1340 (3dfac4b) into master (f4bcc29) will decrease coverage by 0.17%.
The diff coverage is 93.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   89.15%   88.99%   -0.17%     
==========================================
  Files         204      204              
  Lines       12675    12681       +6     
==========================================
- Hits        11300    11285      -15     
- Misses       1375     1396      +21     
Files Changed Coverage Δ
etna/transforms/timestamp/holiday.py 97.82% <93.33%> (-2.18%) ⬇️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 31, 2023

@github-actions github-actions bot temporarily deployed to pull request July 31, 2023 00:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 31, 2023 08:20 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
etna/transforms/timestamp/holiday.py Outdated Show resolved Hide resolved
etna/transforms/timestamp/holiday.py Show resolved Hide resolved
etna/transforms/timestamp/holiday.py Outdated Show resolved Hide resolved
etna/transforms/timestamp/holiday.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request August 2, 2023 01:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 2, 2023 14:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 2, 2023 16:02 Inactive
etna/transforms/timestamp/holiday.py Outdated Show resolved Hide resolved
etna/transforms/timestamp/holiday.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
etna/transforms/timestamp/holiday.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request August 5, 2023 21:25 Inactive
Copy link
Contributor

@Mr-Geekman Mr-Geekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good. There are very small changes requested.

CHANGELOG.md Outdated Show resolved Hide resolved
etna/transforms/timestamp/holiday.py Show resolved Hide resolved
etna/transforms/timestamp/holiday.py Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request August 7, 2023 07:32 Inactive
Mr-Geekman
Mr-Geekman previously approved these changes Aug 7, 2023
@github-actions github-actions bot temporarily deployed to pull request August 7, 2023 11:07 Inactive
@malodetz malodetz merged commit 9824888 into master Aug 7, 2023
12 checks passed
@Mr-Geekman Mr-Geekman deleted the issue-763 branch August 7, 2023 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance HolidaysTransform
3 participants