Skip to content

Make STLTransform to work with NaNs at the beginning #736

Merged
merged 7 commits into from
Jun 7, 2022
Merged

Make STLTransform to work with NaNs at the beginning #736

merged 7 commits into from
Jun 7, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Jun 6, 2022 •
edited
Loading

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Fix the bug.

Related Issue

Look #659.

Closing issues

Closes #659.

@Mr-Geekman Mr-Geekman added the bug Something isn't working label Jun 6, 2022
@Mr-Geekman Mr-Geekman self-assigned this Jun 6, 2022
@github-actions
Copy link

github-actions bot commented Jun 6, 2022 •
edited
Loading

🚀 Deployed on https://deploy-preview-736--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 6, 2022 09:34 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022 •
edited
Loading

Codecov Report

Merging #736 (ae1c83b) into master (aeac093) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #736   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files         121      121           
  Lines        6643     6643           
=======================================
  Hits         5552     5552           
  Misses       1091     1091
Impacted Files Coverage Δ
etna/transforms/decomposition/stl.py 94.44% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@martins0n martins0n self-requested a review June 7, 2022 07:46
martins0n
martins0n reviewed Jun 7, 2022
View reviewed changes
tests/test_transforms/test_decomposition/test_stl_transform.py Show resolved Hide resolved
tests/test_transforms/test_decomposition/test_stl_transform.py Outdated
return df


@pytest.fixture
def df_trend_seasonal_starting_with_nans_one_segment(df_trend_seasonal_one_segment) -> pd.DataFrame:
result = df_trend_seasonal_one_segment.copy()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need copy for reasons below

@github-actions github-actions bot temporarily deployed to pull request June 7, 2022 14:59 Inactive
@martins0n martins0n enabled auto-merge (squash) June 7, 2022 15:11
@github-actions github-actions bot temporarily deployed to pull request June 7, 2022 15:20 Inactive
@martins0n martins0n merged commit 4524927 into master Jun 7, 2022
@Mr-Geekman Mr-Geekman deleted the issue-659 branch June 7, 2022 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@martins0n martins0n martins0n approved these changes

Assignees

@Mr-Geekman Mr-Geekman

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] STLTransform and datasets with nans at the beginning
3 participants
@Mr-Geekman @codecov-commenter @martins0n