Skip to content

Teach catboost to work with encoders #957

Merged
merged 6 commits into from
Sep 27, 2022
Merged

Teach catboost to work with encoders #957

merged 6 commits into from
Sep 27, 2022

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Sep 26, 2022

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

  1. Fix bug encoders and new str/category values.
  2. Make casting for category float types.

Closing issues

Closes #938.

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #957 (4a0d286) into master (1f1f5b6) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
+ Coverage   85.34%   85.50%   +0.16%     
==========================================
  Files         148      148              
  Lines        7951     7963      +12     
==========================================
+ Hits         6786     6809      +23     
+ Misses       1165     1154      -11     
Impacted Files Coverage Δ
etna/models/catboost.py 100.00% <100.00%> (ø)
etna/transforms/encoders/categorical.py 100.00% <100.00%> (ø)
etna/models/tbats.py 94.64% <0.00%> (+1.78%) ⬆️
etna/models/nn/tft.py 100.00% <0.00%> (+1.88%) ⬆️
etna/models/nn/deepar.py 100.00% <0.00%> (+2.27%) ⬆️
etna/auto/utils.py 94.73% <0.00%> (+21.05%) ⬆️
etna/auto/runner/utils.py 100.00% <0.00%> (+50.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Sep 27, 2022

🚀 Deployed on https://deploy-preview-957--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request September 27, 2022 00:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 27, 2022 08:35 Inactive
Copy link
Contributor

@martins0n martins0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martins0n martins0n merged commit 261d930 into master Sep 27, 2022
@martins0n martins0n deleted the issue-938 branch September 27, 2022 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] catboost with ohe
3 participants