You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wanted to suggest a UX change to the pathname input component. Instead of having it's default state be empty, I'd argue that it should always fallback to /. It should also not contain the beginning / if there is an actual pathname entered. Here is a little demonstration of using my forked component:
It is a small change, but after talking to some of my clients, they all felt that this behaviour felt less weird :D
Its a tiny 3-line change, but I am opening this issue to see if this is something you'd want to see, and if it would in some way screw up your setup :)
The text was updated successfully, but these errors were encountered:
Instead of having it's default state be empty, I'd argue that it should always fallback to /.
That makes sense, I missed this because we usually create page documents from the navigator, which sets it by default to "/".
It should also not contain the beginning / if there is an actual pathname entered. Here is a little demonstration of using my forked component:
I disagree here because the idea is that pathname is different from a slug in a way that pathname is absolute and behaves like the window.location.pathname and should always start with /. It might a bit confusing for people used to slugs, but it's how it behaves.
Benefits:
Consistency with the empty state.
Easy of querying. You can always safely compare filter its value based on a route pathname without any additional changes.
Hey gang :)
I wanted to suggest a UX change to the pathname input component. Instead of having it's default state be empty, I'd argue that it should always fallback to
/
. It should also not contain the beginning/
if there is an actual pathname entered. Here is a little demonstration of using my forked component:It is a small change, but after talking to some of my clients, they all felt that this behaviour felt less weird :D
Its a tiny 3-line change, but I am opening this issue to see if this is something you'd want to see, and if it would in some way screw up your setup :)
The text was updated successfully, but these errors were encountered: