Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could this formula be added https://github.com/saltstack-formulas #5

Closed
aboe76 opened this issue Jun 2, 2015 · 5 comments
Closed

Comments

@aboe76
Copy link
Contributor

aboe76 commented Jun 2, 2015

saltstack has a github repo to share formulas

Read this part on sharing:
http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html#writing-formulas

Maybe you would like this formula to be added to that repo? you can keep this repo as upstream.

@aboe76
Copy link
Contributor Author

aboe76 commented Jan 15, 2016

Do I have permission to submit firewalld-formula to saltstack formulas? so others can contribute as well?

@tinuva
Copy link
Owner

tinuva commented Jan 19, 2016

my apologies for only replying now. I did read through the above link the first time last year, and was a bit too busy to comply with all of the guidelines set out.

Did a quick clean up of most commented out lines that is not needed.

Answering your question: I give you permission to upload the firewalld-formula to saltstack formulas on github.

@aboe76
Copy link
Contributor Author

aboe76 commented Jan 19, 2016

@tinuva the information you removed could that be added to the Readme,
because it is usefull to know.

Do you want me to ask saltstack-formula's to fork it and leave you're github as upstream,
so you can merge contributions back?

@tinuva
Copy link
Owner

tinuva commented Jan 19, 2016

If possible for them to do that, that will be awesome, otherwise I dont mind at all having this project donated to them, as I can see how it will help others going forward.

@aboe76
Copy link
Contributor Author

aboe76 commented Jan 19, 2016

OK I have forked the repo in the saltstack-formula's repo,

@aboe76 aboe76 closed this as completed Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants