Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on consistent UI pattern for user confirmation #1683

Open
jotaen4tinypilot opened this issue Nov 13, 2023 · 0 comments
Open

Decide on consistent UI pattern for user confirmation #1683

jotaen4tinypilot opened this issue Nov 13, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request medium

Comments

@jotaen4tinypilot
Copy link
Contributor

jotaen4tinypilot commented Nov 13, 2023

I don’t think we follow a deliberate pattern in the UI as to when we require confirmation after button clicks in dialogs. E.g.:

  • In the upcoming “Static IP” feature, we’ll have a separate confirmation prompt before removing the static IP address.
  • In the <security-dialog> component, we have a confirmation prompt when toggling off the auth requirement.
  • Apart from that, I don’t think we have such a confirmation in any of our other dialogs, including the ones that carry out destructive and potentially “harmful” operations, such as:
    • Removing individual users
    • Disabling the HTTPS enforcement
    • Changing the hostname (which causes a device reboot)
    • Removing disk images (which are potentially very slow to upload)

Not having any confirmation for these kinds of operations actually makes me feel slightly uneasy. (I’m not sure how e.g. customers feel about that, though, or whether we have ever received “angry” feedback about this.)

In any event, I think we should define our desired UX pattern for user confirmation in the style guide, and then roll out the rules in the entire UI.

UI-wise, there are different patterns for user confirmation. Apart from the aforementioned separate confirmation step/prompt, there are also more light-weight patterns we could consider.

@jotaen4tinypilot jotaen4tinypilot added the enhancement New feature or request label Nov 13, 2023
@mtlynch mtlynch added the medium label Nov 13, 2023
@jotaen4tinypilot jotaen4tinypilot self-assigned this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium
Projects
None yet
Development

No branches or pull requests

2 participants