Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the scheduler state volatile #327

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Make the scheduler state volatile #327

merged 1 commit into from
Mar 1, 2024

Conversation

eufrizz
Copy link
Contributor

@eufrizz eufrizz commented Mar 1, 2024

  • The state variable is altered in the interrupts, thus should be marked volatile.
  • Without it, compiler optimisations could have unexpected effects
  • This was the cause of Doesn't run with compiler optimisations #216
  • I made it static too as it is only part of scheduler.c

@eufrizz eufrizz mentioned this pull request Mar 1, 2024
Closed
@yconst
Copy link
Collaborator

yconst commented Mar 1, 2024

Good catch, thanks!

@yconst yconst merged commit 5d1c0cd into tinymovr:develop Mar 1, 2024
1 check passed
@eufrizz eufrizz deleted the bugfix-volatileSchedulerState branch March 4, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eufrizz @yconst