This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Revert non-upstream merges #153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrepl: handle "other" events
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Add Flavor as a conn param. Add code to handle flavor-specific GTID. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
In this scheme, the filePos reader detects whether we are in a transaction or not, and emits appropriate GTID events. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
The vstreamer sent GTIDs "as they came". With the new change, GTIDs are sent only when they matter: on COMMIT, DDL or OTHER. This new approach makes the protocol easier to understand. Also, it makes it easier for filePos to continuously send file and position. The correct values will get used when significant events like COMMIT are encountered. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Maxim Krasilnikov <mak.krasilnikov@gmail.com> Signed-off-by: Maxim Krasilnikov <m.krasilnikov@space307.com>
The vplayer currently uses ambiguous rules about how it handles the case where a stop position was exceeded. As part of this change, we'll standardize on: A stop position is considered to be successfully reached if the new position is greater than or equal to the specified position. The main motivation for this change is that the possibility of position mismatch is higher in the case of file:pos tracking. We're likely to hit many false positives if we're too strict. Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: lokune <laban.okune@ma3route.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Sugu Sougoumarane <ssougou@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
etcd on unstable or unsupported architectures will print a warning message and immediately exit if the environment variable ETCD_UNSUPPORTED_ARCH is not set to the target architecture. Change-Id: Ifdd3ed4ae322484477d2db3e2d0eed09e086518f Signed-off-by: Jiamei.Xie <Jiamei.Xie@arm.com>
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
Eliminate that it isn't transient state causing it to fail. Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Harshit Gangal <harshit.gangal@gmail.com>
Add a line to install pip package which is needed for later steps. Signed-off-by: Nick Canzoneri <nickcanz@github.com>
Update vagrant bootstrap to install pip
Search for etcd in PATH, don't install if installed
In xtrabackup mode, we would normally leave replication running when taking a backup on a tablet. However, since this is not a serving tablet, we stop replication in advance to help make xtrabackup's job easier. Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
Signed-off-by: xichengliudui <1693291525@qq.com>
Not used by default. To use: * Set LD_PRELOAD=/usr/lib/libtcmalloc_minimal.so.4 * or LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libjemalloc.so.1 in your container startup environment. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
…y-of-tls-certificate-per-file Load tls certificate and x509 cert pool once per file to reduce memory usage
* Fixed nil bind variables error by resetting bindvars to an empty map. Also added a recover to catch panics that occur inside Logf due to FormatBindVariables call potentially panicking. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com> * Changed import order back. Order was auto-changed by IDE on save Signed-off-by: Peter Farr <Peter@PrismaPhonic.com> * Using stored ParamsCount for capacity per review suggestion. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com> * Added explanation comment per review suggestion. Signed-off-by: Peter Farr <Peter@PrismaPhonic.com> * Removed explicit panic after offline talk with sougou and deepthi Signed-off-by: Peter Farr <Peter@PrismaPhonic.com>
vreplication: file:pos flavor
Fix some static check errors
EndtoEnd test cases in Go migrated from Python
Flatten/Merge VTTOP and VTROOT variables
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Minor spelling/grammar improvements Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
Fixes vitessio#5421 Signed-off-by: Morgan Tocker <tocker@gmail.com>
Signed-off-by: Morgan Tocker <tocker@gmail.com>
This allows bootstrap to eventually be deprecated. Signed-off-by: Morgan Tocker <tocker@gmail.com>
…kging Make packages with cut down binaries list
Add golangci-lint with linters disabled
…dency-chk Add better dependency checking
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Slack sync upstream 2019 11 09.r0
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Slack sync upstream 2019 12 11.r0
…ke-master DeleteTablet: allow deletion of old master tablet without -allow_master
We've gotten reports from Vitess users who use the consultopo plugin that watches sometimes remain stalled following a network partition, even after the process regains contact with the topo server. This change should help us detect when a consultopo watch connection has silently died while waiting for a long poll response. I haven't thought of a good way to test this since this kind of zombie TCP connection should only happen if even the "connection closed" signal cannot be delivered (like in a network partition, as opposed to a process crash). Signed-off-by: Anthony Yeh <enisoc@planetscale.com>
Healthcheck - limit healthchecks by keyspace
…undo PlannedReparent: create a new context for calling UndoDemoteMaster
Log when we fail to accept a conn
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Slack vitess 2020 03 11.r0
This reverts commit f0d747a.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts our last build (#148), as well as on old PR (#126) that never got merged to upstream.