Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

titan init overwrite idea #1

Closed
tcrowe opened this issue Aug 9, 2018 · 5 comments
Closed

titan init overwrite idea #1

tcrowe opened this issue Aug 9, 2018 · 5 comments
Assignees
@ToJen
Labels
good first issue Good for newcomers

Comments

@tcrowe
Copy link
Contributor

tcrowe commented Aug 9, 2018

Hey guys 👋

When I did titan init it blew away my package.json. It's not a problem as one should expect any init to write to a fresh directory. Maybe it could give a warning (y/n)? in the prompt.

Did you ever talk about that?
@ToJen ToJen self-assigned this Aug 9, 2018
@ToJen ToJen added the good first issue Good for newcomers label Aug 9, 2018
@ToJen
Copy link
Contributor

ToJen commented Aug 9, 2018

Hey @tcrowe, thanks for pointing that out. I will probably have a titan init <dApp-name> or instruct the user to init in a new folder or like you said give the (y/n)? prompt.

@ToJen
Copy link
Contributor

ToJen commented Aug 10, 2018

Fixed in commit aba19e7

@ToJen ToJen closed this as completed Aug 10, 2018
@tcrowe
Copy link
Contributor Author

tcrowe commented Aug 10, 2018

Thank you @ToJen. I will try this later

@ToJen
Copy link
Contributor

ToJen commented Aug 12, 2018

Thanks. Btw what version of node are you running?

@tcrowe
Copy link
Contributor Author

tcrowe commented Aug 12, 2018

v9.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ToJen ToJen

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tcrowe @ToJen