Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESM build version still has test output #1

Closed
tivac opened this issue Aug 1, 2018 · 1 comment
Closed

ESM build version still has test output #1

tivac opened this issue Aug 1, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@tivac
Copy link
Owner

tivac commented Aug 1, 2018

When using rollup to bundle aws-sig and the rollup-plugin-node-resolve plugin the following code isn't removed from the deployed version:

aws-sig/src/index.js

Lines 88 to 95 in 5197cb8

/* START.TESTSONLY */
// Add partial output to response for tests
source.test = {
canonical,
sts,
auth,
};
/* END.TESTSONLY */

It's visible on unpkg.com in the bundled output for the .esm.js version.

@tivac tivac added the bug Something isn't working label Aug 1, 2018
@tivac tivac self-assigned this Aug 1, 2018
@tivac
Copy link
Owner Author

tivac commented Aug 2, 2018

Fixed by 77a5155, fix released as aws-sig@1.2.2

@tivac tivac closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant