Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stock generated script is not runnable #42

Closed
suan opened this issue Mar 2, 2012 · 1 comment
Closed

Stock generated script is not runnable #42

suan opened this issue Mar 2, 2012 · 1 comment

Comments

@suan
Copy link
Contributor

suan commented Mar 2, 2012

I'm not sure why commander tries to require 'myscript'in the generated template when I specify 'myscript' as the "Machine name" - I would think that for most commander use cases you're not looking to load a gem with the same name as your script...

In addition, the ':version' is not set to something correct, but is instead set to Myscript::VERSION.

These 2 things prevent a stock generated script from actually running without erroring out.

I propose removing the require statement, and setting the default version to '0.0.1'. Also, I think the "Machine name" prompt is unnecessary. Wouldn't it make sense to just use the filename of the file passed in as the init argument?

Don't mean to sound negative, but these things just seem bewildering to me :)

@ggilder
Copy link
Collaborator

ggilder commented Mar 2, 2012

I agree with you, I'm not really sure why the original decision was made to set it up like that. I agree with your suggestions, and if you have the time to put together a pull request, that would be awesome...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants