Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation on pull-request command #450

Closed
blakeembrey opened this issue Sep 21, 2015 · 5 comments
Closed

Missing documentation on pull-request command #450

blakeembrey opened this issue Sep 21, 2015 · 5 comments

Comments

@blakeembrey
Copy link

Not sure where the best place to get started is here, but the documentation (both man pages and from Commands.md) is missing. I'd like to work on this and maybe add some tests for any others that are missing, if you could point me in the right direction 😄

@nicolaiskogheim
Copy link
Collaborator

Good to hear!

We create our man pages and html versions from markdown. Create a file called git-pull-request.md in the man directory, and when you want to se how it looks:

make docs
man ./man/git-pull-request

And then you should see your man-page. You will need the ruby-gem ronn to generate the man-pages.

I suggest you look at some of the other man pages to get ideas. You can copy the contents of one of the markdown files and go from there. We try to mimick the git man pages in wording and style. There are, though, some styling limitations because of ronn, as you will see (I'm thinking about the very padded examples, among other things).

When you have a good man page, you will also have examples and a description which you can reuse in Commands.md.

Feel free to open a PR early, and we can discuss things as you go. :)

@al-the-x
Copy link
Contributor

al-the-x commented Dec 1, 2015

@blakeembrey Do you have a PR for this yet? Happy to assist...

@blakeembrey
Copy link
Author

I don't, sorry! Caught up with lots of things, I'd appreciate if someone else wanted to pick this up 😄

@al-the-x
Copy link
Contributor

al-the-x commented Dec 3, 2015

Happy to give it a go, then.

@tfendin
Copy link
Contributor

tfendin commented Dec 29, 2021

This issue seems to be fixed now, could be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@al-the-x @blakeembrey @nicolaiskogheim @spacewander @tfendin and others