Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update includes #2

Closed
tj opened this issue Feb 15, 2017 · 3 comments
Closed

Update includes #2

tj opened this issue Feb 15, 2017 · 3 comments

Comments

@tj
Copy link
Owner

tj commented Feb 15, 2017

Need a way to refresh the contents

@tj tj changed the title Update Update includes Feb 15, 2017
@rpunkfu
Copy link

rpunkfu commented Feb 23, 2017

Maybe store a dotfile with timestamp of last update in folder where github dependency is downloaded and when we run mmake it decides whether to check git for newer version and fetches if found? Let me know what you think, I'll probably have some time to implement this over the weekend :)

@tj
Copy link
Owner Author

tj commented Feb 24, 2017

Currently it skips if there's already something local (https://github.com/tj/mmake/blob/master/installer/installer.go#L119), so we wouldn't be able to compare without adding a bit of extra latency each time.

It might not be horrible to leave it as make update or something manual so it doesn't scare people magically fetching potentially new/malicious code haha. With that I guess we'd only need an Installer field to bypass the stat().

@rpunkfu
Copy link

rpunkfu commented Feb 24, 2017

Yeah, manual option would be nicer, maybe just force flag for installDependency would be enough, dunno ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants