Contributing back from a fork

[zph]

Hi @tj,

I like the concept of this project and looked through forks and PRs to bring it current and extend it for a few desired features. Repo: https://github.com/zph/mmake

• Allow direct http/s based includes via new resolver
• Support standard makefile names (per GNUMake, ie GNUmakefile, makefile, or Makefile) Allow using both Makefile and GNUmakefile #33 (though I rewrote this one myself)
• Allow custom include paths Support a custom includes path #25
• Highlight default target Highlight the default target #29
• Fixed tests broken by custom include path.
• Use goreleaser
• Setup a brew recipe for installation on mac/linux
• Use golang modules for dependency tracking/download
• Implements Tag / commit support #3 tag/commit/sha support for github based resolver

I want to make sure to contribute back and am happy to do any of the following:

• Merge this back into your repo and optionally get a commit bit to tidy up the issues/PRs
• Maintain my own copy indefinitely
• Or another combination of these :).

Thanks for putting this project together and if any of these outcomes sound good, great! If not, I'm quite happy to have my own repo for it too 👍.

Cheers,
ZPH

[tj]

nicely done! I'm happy with the current functionality as-is for my personal use, but if you're interested I can add you as a collaborator. As long as the existing stuff works I'm happy

[zph]

@tj 👋. I'm happy to be a contributor, clean up PRs/issues, and bring that functionality back into the main repo, with the guiding principle of "Keep this backwards compatibility for @tj's use cases".

I'm interpreting your use cases as the current behavior specced out in docs and tests relating to:

• make help
• include github.com/foo/bar style syntax
• etc

💃 sounds fun! This project has my attention at the moment and it was an elegant mechanism you setup for bringing them into the include path, to work seamlessly with existing make.

TLDR: please add me when you get a chance.

[zph]

@tj Protocol question: when I put up PRs for those features coming over:

• Do you want to approve/merge them?
• Have me post them and then merge them?
• Post and have another contributer review/approve?

[tj]

That sounds good to me! I can still help review/approve stuff. All the features you listed in the top of this issue sound great to me, appreciate the help!

[zph]

Grand :). I'll see about how to sensibly partition the changes into PR sized chunks!

Happy to help and glad you wrote this project 👍

[zph]

Closing this as done (enough) 👯‍♂and marked off the things complete vs outstanding from initial comment 🕺.

Thanks @tj.

[zph]

If anyone's interested in implementing #3, by repurposing my code from fork, they're welcome to cherry pick the commits and polish it up for production.