Rework activate to support more configurations #657
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Ideally copying the files during install would be a simpe command. Not so in practice! The original two folder copies have grown over the years to cope with special cases and add functionality.
Problem
find
andcp
rsync
cp
rsync
for--preserve
/usr/local/share/man
, such as archinux (Error when copying.../share/man
#100)n exec
would pollute cache and affect later installsSolution
Use hand-crafted code for install using just
find
andcp
. Use same code independent of symlinks.Only copy known binaries and expected node_modules to mitigate cache pollution (
n exec
).A downside is slightly less robust about future changes to what is contained in archive.
ChangeLog
/usr/local/share/man
is a symlink (such as archlinux)rsync
for--preserve
n exec