Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.8.1 fails to compile for no-std #141

Closed
schungx opened this issue Nov 5, 2022 · 2 comments
Closed

0.8.1 fails to compile for no-std #141

schungx opened this issue Nov 5, 2022 · 2 comments

Comments

@schungx
Copy link
Contributor

schungx commented Nov 5, 2022

The added feature of getrandom/js is breaking no-std builds by pulling in wasm-bindgen (for no reason).

EDIT: rust-lang/cargo#4866 and rust-lang/cargo#1197 document the fact that target-specific features are not supported. All features are merged regardless of target.

This is an issue in addition to #140.

@schungx
Copy link
Contributor Author

schungx commented Nov 5, 2022

I strong concur with #140 that the best solution is to add a js feature which turns on getrandom/js.

JavaScript interop is really an external feature outside of core target architecture and O/S, so it is reasonable to assume that it should be specifically specified.

Assuming the existence of JavaScript for all wasm and no-std targets is simply wrong; since not all warm runs on a browser, and no-std most likely doesn't have JavaScript around.

@tkaitchuck
Copy link
Owner

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants