Add timestamps class #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moi15moi
reviewed
Jan 30, 2023
pysubs2/time.py
Outdated
| ValueError: fps was negative or zero. | ||
|
|
||
| """ | ||
| return Timestamps.from_fps(fps).frames_to_ms(frames) |
There was a problem hiding this comment.
You need to add the parameter to precise the TimeType
pysubs2/time.py
Outdated
| ValueError: fps was negative or zero. | ||
|
|
||
| """ | ||
| return Timestamps.from_fps(fps).ms_to_frames(ms) |
There was a problem hiding this comment.
You need to add the parameter to precise the TimeType
moi15moi
reviewed
Jan 30, 2023
| @@ -122,7 +122,7 @@ def ms_to_frames(ms: IntOrFloat, fps: float) -> int: | |||
| ValueError: fps was negative or zero. | |||
|
|
|||
| """ | |||
| return Timestamps.from_fps(fps).ms_to_frames(ms) | |||
| return Timestamps.from_fps(cast(Real, fps)).ms_to_frames(int(ms)) | |||
There was a problem hiding this comment.
You need to add the parameter to precise the TimeType
| @@ -104,7 +104,7 @@ def frames_to_ms(frames: int, fps: float) -> int: | |||
| ValueError: fps was negative or zero. | |||
|
|
|||
| """ | |||
| return Timestamps.from_fps(fps).frames_to_ms(frames) | |||
| return Timestamps.from_fps(cast(Real, fps)).frames_to_ms(frames) | |||
There was a problem hiding this comment.
You need to add the parameter to precise the TimeType
moi15moi
reviewed
Jan 30, 2023
| continue | ||
| except ValueError: | ||
| raise UnknownFPSError("Framerate was not specified and " | ||
| "cannot be read from " | ||
| "the MicroDVD file.") | ||
|
|
||
| start, end = map(partial(frames_to_ms, fps=fps), (fstart, fend)) | ||
| # I chose the format SRT, but it could be anyone. | ||
| # SRT simply has a precision in milliseconds which can be better. |
There was a problem hiding this comment.
This comment need to be remove
|
@tkarabela You may wanna see what I added in my branch Add-timestamps-class-v2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will implement #57.