Add timestamps class v2 #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en frames or fps is None
… Also, reformat code
In general, player like mpv or mpc round up. If the ms is 0.5, it will round to 1. So, this commit reproduce this type of rounding, but there is no standard in the video industry
An subtitle cannot contain negative timestamps, so we make it 0
If the fps was invalid, Timestamps.from_fps would raise an ValueError that would been catched. We don't want that, so I moved out the call to from_fps of the try except
|
Hi @moi15moi, do you plan to add more commits or is this ready to merge? :) |
|
It would be ready except if you find that the end_time of the microdvd is exclued. Also, you may wanna see how the shift method is currently done. |
|
Ok :) I will look at the code when I have time and merge it. |
Here is the video I used to test this behaviour: https://github.com/lincolnneu/video_frame_rate/blob/master/key_frame_rate_1/120.mp4
Hi, would you check it soon? |
|
Hi, here is a little bump to know if you will be able to review the PR soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will implement #57.
Is also overwrite this PR #65.
Important to note, I haven't been able to get the information if the microdvd end frame value is inclued or not.
Aegisub consider it like inclued, so I decided to do like them. Edit (2023-04-29): I test with ffmpeg. It also inclued the end_frame.
Because of that, I needed to change the value of some tests.