Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be more conservative about attribute escaping #7

Open
tkluck opened this issue Apr 26, 2020 · 0 comments
Open

Be more conservative about attribute escaping #7

tkluck opened this issue Apr 26, 2020 · 0 comments

Comments

@tkluck
Copy link
Owner

tkluck commented Apr 26, 2020

Attribute escaping breaks e.g. charset declarations (at least in firefox), leading to [workarounds like this(https://github.com/tkluck/StatProfilerHTML.jl/blob/109ad6f/haml/index.hamljl#L4). This issue is also reported by @mlhetland in #6 . We could fix this by e.g. only escaping "; maybe there's authoritative behaviour documented somewhere?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tkluck