Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isabelle202X cleanup #131

Merged
merged 10 commits into from
Aug 18, 2024
Merged

Isabelle202X cleanup #131

merged 10 commits into from
Aug 18, 2024

Conversation

kape1395
Copy link
Collaborator

Reorganized Isabelle's build sessions to use a single root file.

Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
@kape1395
Copy link
Collaborator Author

@muenchnerkindl, the file isabelle/examples/AtomicBakeryG.thy has failing steps.
Maybe you could check if the proof needs to be updated or if the main theory needs to be fixed.

@kape1395
Copy link
Collaborator Author

At least some of the failures are also caused by Nat/Int. E.g.

    with type have n: "num[i] ∈ Nat" (* by (auto simp: TypeOK_def) *)
    proof -
      have "num ∈ [ProcSet → Nat]" sorry
      thus "num[i] ∈ Nat" by auto
    qed

Here thus "num[i] ∈ Nat" by auto fails with

Failed to finish proof:
goal (2 subgoals):
 1. num ∈ [ProcSet → Nat] ⟹ num[i] ∈ Int
 2. num ∈ [ProcSet → Nat] ⟹ 0 ≤ num[i]

@muenchnerkindl, maybe it's worth removing the Nat -> Int rewrite and proving the Nat properties explicitly?

Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
… tests.

Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
@kape1395 kape1395 marked this pull request as ready for review May 29, 2024 20:18
@kape1395
Copy link
Collaborator Author

@muenchnerkindl, I have excluded AtomicBakeryG.thy from the test cases for now. Can I merge it as is?

kape1395 and others added 7 commits May 31, 2024 06:54
… n).

Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Stephan Merz <stephan.merz@loria.fr>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Signed-off-by: Karolis Petrauskas <k.petrauskas@gmail.com>
Rewrite Nat to {x ∈ Int : 0 ≤ x} instead of n ∈ Nat to (n ∈ Int ∧ 0 ≤ n).
Make `isabelle/examples` built during the tests.
@kape1395 kape1395 merged commit b8a6899 into isabelle2020-dune Aug 18, 2024
1 check passed
@kape1395 kape1395 deleted the isabelle2020-dune-cleanup branch August 18, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants