Contributions through pull requests are most welcome!
Please read the whole document before contributing, to minimize the chances of your change being rejected.
Please follow these few guidelines, to make sure your pull request will be accepted:
- read and follow the coding standard
- add a test for the features added
- make sure it builds and all tests pass
- if it's a major change, or fixes a high priority bug, add a new change to the changelog
- squash the commits to the required minimum, and name them correctly
- keep your commits small and contain one task or one fix (keep it "atomic")
All pull requests have to be filed against the master
branch, since this is
where all of the development is happening.
Pull requests to other branches will not be accepted.
- Separate subject from body with a blank line
- Limit the subject line to 50 characters
- Capitalize the subject line
- Do not end the subject line with a period
- Use the imperative mood in the subject line
- Wrap the body at 72 characters
- Use the body to explain what and why vs. how
Complete example:
Summarize changes in around 50 characters or less
More detailed explanatory text, if necessary. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical (unless
you omit the body entirely); various tools like `log`, `shortlog`
and `rebase` can get confused if you run the two together.
Explain the problem that this commit is solving. Focus on why you
are making this change as opposed to how (the code explains that).
Are there side effects or other unintuitive consequences of this
change? Here's the place to explain them.
Further paragraphs come after blank lines.
- Bullet points are okay, too
- A hyphen is used for the bullet, preceded by a single space, with blank
lines in between, and continuations are done on the same paragraph as the
beginning
Put references to issues resolved or related at the bottom:
Resolves: #123
See also: #456, #789
My submitting a patch you agree to license your patch under the MIT License.