Set node 14 as minimum supported version #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi all! This thread has not had any recent activity. |
|
@MasterOdin is this ready to be merged? |
owenvoke
approved these changes
Jul 29, 2022
|
Hi all! This thread has not had any recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR drops support for node 12 as it's reached end of life and is no longer supported. I've also replace node 17 with node 18 in the test matrix as the former is also end of life and the latter is the upcoming LTS release so we should verify it works. However, since we're not making any changes to explicitly support node 18 and that node 17 isn't LTS, I don't think we need to call this change out in a separate commit.