Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages/*: add standard translation and links #11331

Merged
merged 10 commits into from
Nov 2, 2023
Merged

pages/*: add standard translation and links #11331

merged 10 commits into from
Nov 2, 2023

Conversation

kbdharun
Copy link
Member

@kbdharun kbdharun commented Oct 29, 2023

Signed-off-by: K.B.Dharun Krishna kbdharunkrishna@gmail.com

Changes

  • Add Finish translation to More information link.
  • Standardize period in More information link for Bengali, Hindi, and Nepali from . to .
  • Run set-alias-page.py script (as there has been 3 language additions since the last time I ran this script last year) to automatically generate alias pages based on the translation template.
  • Run set-more-info-link.py script to automatically update links throughout the translation pages.

Note: This PR won't be ready for review for at least the next couple of days, while I work on eliminating the false positives (which I am aware of), especially with the Windows pages (we had similar ones in #9672 too, and I manually went through all the pages and eliminated them).


FAQ

How do I check/review these changes?

Since this PR modified a lot of lines (in hundreds of pages), GitHub diff wouldn't load even a fraction of the changed files and would often crash. So once it is ready for review you can either create a GitHub codespace or use VSCode locally with the GitHub (PR and main extensions loaded). This allows seamless reviewing and keeping track of all the changes).

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@kbdharun kbdharun added the script-runs PRs where the scripts were executed (i.e alias page translations, etc). label Oct 29, 2023
@github-actions github-actions bot added the translation Translate pages from one language to another. label Oct 29, 2023
@kbdharun kbdharun added the mass changes Changes that affect multiple pages. label Oct 29, 2023
sebastiaanspeck and others added 2 commits October 30, 2023 12:56
Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes the alias pages are broken. When the english version links to more than one page, the (german) translation only links to one page.

@@ -0,0 +1,7 @@
# just

> Dieser Befehl ist ein Alias von `just.1`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just is an alias for two pages. See the english version: https://github.com/tldr-pages/tldr/blob/main/pages/common/just.md

@@ -0,0 +1,7 @@
# open

> Dieser Befehl ist ein Alias von `open -p osx`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also an alias for multiple pages: https://github.com/tldr-pages/tldr/blob/main/pages/common/open.md Might be a bug in the script you used to create these pages.

@kbdharun
Copy link
Member Author

kbdharun commented Oct 30, 2023

Sometimes the alias pages are broken. When the english version links to more than one page, the (german) translation only links to one page.

Yep, this is exactly what I asked in the chatroom about.


I will drop off the whole message here:

Hi, so I need your opinion on this PR #11331. I have fixed the false positives for modified files. But there might be places in the new additions where a few commands might be missing (as the script only works for translation pages matching the exact translation page template [which only supports a single example] + 1 line more info link) and not any other modifications.

Last time when we executed the script last year, we decided to leave the pages to be fully completed by translators and merged the PR. Should we do the same this time to reduce the tedious reviewing process for maintainers or should we go with the process of manually completing the pages (for which we have native reviewers)?

I personally prefer the first option as working on independent PRs to complete the missing commands (on alias pages) would be better for reviewing and also organizing.

@sebastiaanspeck
Copy link
Member

Maybe add bn to this line?

@kbdharun
Copy link
Member Author

kbdharun commented Oct 31, 2023

Maybe add bn to this line?

I think I already did it in this PR. Will check the file and get back.

Edit. Yep, added it in cb9061b.

@kbdharun kbdharun requested a review from gutjuri November 2, 2023 08:31
@kbdharun kbdharun merged commit 39642c3 into main Nov 2, 2023
8 checks passed
@kbdharun kbdharun deleted the chore/scripts branch November 2, 2023 17:22
@acuteenvy acuteenvy removed their request for review November 2, 2023 17:39
kbdharun added a commit that referenced this pull request Nov 3, 2023
kbdharun added a commit that referenced this pull request Nov 4, 2023
kbdharun added a commit that referenced this pull request Nov 6, 2023
kbdharun added a commit that referenced this pull request Nov 6, 2023
* pages/*: add standard translation and links

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* fix1: false positives; standardize Bengali, Hindi, Nepali periods

* fix: periods in recently added Bengali pages

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* fix: false positives in modified files

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* cleanup: update to native period in Bengali l10n

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

---------

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
kbdharun added a commit that referenced this pull request Nov 6, 2023
sebastiaanspeck pushed a commit that referenced this pull request Nov 6, 2023
* pages/*: add standard translation and links

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* fix1: false positives; standardize Bengali, Hindi, Nepali periods

* fix: periods in recently added Bengali pages

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* fix: false positives in modified files

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* cleanup: update to native period in Bengali l10n

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

---------

Signed-off-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
sebastiaanspeck pushed a commit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mass changes Changes that affect multiple pages. script-runs PRs where the scripts were executed (i.e alias page translations, etc). translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants