Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages.pl/*: add and update pages; git-stage, linode-cli: update page #11365

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

acuteenvy
Copy link
Member

#11331 added a lot of misleading pages:

  • lzegrep, zstdcat, etc.: English pages specify exactly what those aliases refer to (e.g. lzegrep => xzgrep --extended-regexp). In other languages, the additional argument is gone - the pages provide invalid information.
  • docker-*: In English, subcommands are space-separated. In other languages, they are hyphen-separated, and there is, for example, no such command as docker-container-rm.
  • linode-cli, just, etc. (disambiguation pages): The disambiguation is only present in English. Of course, these can't be automatically translated, so they should have just been left out by the script.
  • open: Another disambiguation page, this time the translation says that this is an alias of open -p osx - there is no such command.

... and probably many more pages with similar issues.


This script should be updated to leave out the pages that are not exact aliases because otherwise, this leads to the creation of misleading pages that then need to be manually taken care of.

@github-actions github-actions bot added page edit Changes to an existing page(s). translation Translate pages from one language to another. labels Nov 2, 2023
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes.

@kbdharun
Copy link
Member

kbdharun commented Nov 3, 2023

This script should be updated to leave out the pages that are not exact aliases because otherwise, this leads to the creation of misleading pages that then need to be manually taken care of.

Agreed, when I work on adding documentation for the scripts directory (as specified in the tracker issue). I will specify a new requirement that this script must be run for new translations/their native language only and not on other ones. And will suggest only staging changes for the directory i.e git add pages.<locale>. And later they can work on fixing the false positives and translations.

This would be far easier to review and fix when compared to running the script for all the locales.

@acuteenvy
Copy link
Member Author

I honestly think #11331 should be reverted for languages which we don't have a maintainer for. We're going to be stuck with clients showing completely invalid information for a long time in these languages.

@acuteenvy acuteenvy mentioned this pull request Nov 3, 2023
35 tasks
@acuteenvy acuteenvy added the mass changes Changes that affect multiple pages. label Nov 3, 2023
@kbdharun
Copy link
Member

kbdharun commented Nov 3, 2023

I honestly think #11331 should be reverted for languages which we don't have a maintainer for. We're going to be stuck with clients showing completely invalid information for a long time in these languages.

Agreed, will create a PR to revert it later today. And will port link changes to a seperate PR.

@kbdharun
Copy link
Member

kbdharun commented Nov 3, 2023

Done #11374, once it gets merged I will work on backporting other changes.

@kbdharun kbdharun changed the title pages.pl/*: fix standard translations pages.pl/*: add and update pages Nov 4, 2023
@sebastiaanspeck sebastiaanspeck marked this pull request as ready for review November 4, 2023 08:42
@kbdharun kbdharun marked this pull request as draft November 4, 2023 12:44
@sebastiaanspeck
Copy link
Member

Any update on this?

@acuteenvy
Copy link
Member Author

Any update on this?

You can merge it I guess, I'll do all the other platforms later.

@acuteenvy acuteenvy marked this pull request as ready for review November 8, 2023 18:43
@github-actions github-actions bot added documentation Issues/PRs modifying the documentation. new command Issues requesting creation of a new page. labels Nov 8, 2023
@acuteenvy acuteenvy removed the documentation Issues/PRs modifying the documentation. label Nov 8, 2023
@sebastiaanspeck
Copy link
Member

Maybe it needs a good rebase first?

@acuteenvy
Copy link
Member Author

I'm trying, but the force pushing messed everything up. You can rebase it yourself if you manage to do it.

@sebastiaanspeck
Copy link
Member

Fixed! If we squash the 9 commits into 1, it looks we only have the Polish changes

@acuteenvy
Copy link
Member Author

I rebased it again because I added some more changes. Thank you, this should be mergeable now.

@acuteenvy acuteenvy changed the title pages.pl/*: add and update pages pages.pl/*: add and update pages; git-stage, linode-cli: update page Nov 8, 2023
@sebastiaanspeck sebastiaanspeck merged commit 224b297 into tldr-pages:main Nov 8, 2023
4 checks passed
@acuteenvy acuteenvy deleted the pl-fix-11331-stdtrans branch November 8, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mass changes Changes that affect multiple pages. new command Issues requesting creation of a new page. page edit Changes to an existing page(s). translation Translate pages from one language to another.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants