-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pages.pl/*: add and update pages; git-stage, linode-cli: update page #11365
pages.pl/*: add and update pages; git-stage, linode-cli: update page #11365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes.
Agreed, when I work on adding documentation for the scripts directory (as specified in the tracker issue). I will specify a new requirement that this script must be run for new translations/their native language only and not on other ones. And will suggest only staging changes for the directory i.e This would be far easier to review and fix when compared to running the script for all the locales. |
I honestly think #11331 should be reverted for languages which we don't have a maintainer for. We're going to be stuck with clients showing completely invalid information for a long time in these languages. |
Agreed, will create a PR to revert it later today. And will port link changes to a seperate PR. |
Done #11374, once it gets merged I will work on backporting other changes. |
5d0d9a0
to
f402eee
Compare
Any update on this? |
You can merge it I guess, I'll do all the other platforms later. |
9f06438
to
50f8a0a
Compare
Maybe it needs a good rebase first? |
I'm trying, but the force pushing messed everything up. You can rebase it yourself if you manage to do it. |
50f8a0a
to
0547e4e
Compare
Fixed! If we squash the 9 commits into 1, it looks we only have the Polish changes |
0547e4e
to
23c275b
Compare
I rebased it again because I added some more changes. Thank you, this should be mergeable now. |
#11331 added a lot of misleading pages:
lzegrep
,zstdcat
, etc.: English pages specify exactly what those aliases refer to (e.g.lzegrep
=>xzgrep --extended-regexp
). In other languages, the additional argument is gone - the pages provide invalid information.docker-container-rm
.linode-cli
,just
, etc. (disambiguation pages): The disambiguation is only present in English. Of course, these can't be automatically translated, so they should have just been left out by the script.open
: Another disambiguation page, this time the translation says that this is an alias ofopen -p osx
- there is no such command.... and probably many more pages with similar issues.
This script should be updated to leave out the pages that are not exact aliases because otherwise, this leads to the creation of misleading pages that then need to be manually taken care of.