Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nuclei: add page #12252

Merged
merged 14 commits into from Feb 15, 2024
Merged

nuclei: add page #12252

merged 14 commits into from Feb 15, 2024

Conversation

fazlearefin
Copy link
Member

@fazlearefin fazlearefin commented Feb 13, 2024 •
edited

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@fazlearefin fazlearefin added the new command Issues requesting creation of a new page. label Feb 13, 2024
Magrid0
Magrid0 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@Magrid0 Magrid0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for your contribution!

vitorhcl
vitorhcl requested changes Feb 13, 2024
View reviewed changes
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, it has many helpful examples. I have some suggestions for this page.

pages/common/nuclei.md Outdated Show resolved Hide resolved
pages/common/nuclei.md Outdated Show resolved Hide resolved
pages/common/nuclei.md Outdated Show resolved Hide resolved
pages/common/nuclei.md Outdated Show resolved Hide resolved
pages/common/nuclei.md Outdated Show resolved Hide resolved
pages/common/nuclei.md Outdated Show resolved Hide resolved
pages/common/nuclei.md Outdated Show resolved Hide resolved
fazlearefin and others added 7 commits February 14, 2024 17:32
@fazlearefin @vitorhcl
Update pages/common/nuclei.md
bff63c7 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin @vitorhcl
Update pages/common/nuclei.md
ba2d9e3 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin @vitorhcl
Update pages/common/nuclei.md
6f1e181 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin @vitorhcl
Update pages/common/nuclei.md
e029832 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin @vitorhcl
Update pages/common/nuclei.md
72a6a52 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin @vitorhcl
Update pages/common/nuclei.md
e958ee9 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin @vitorhcl
Update pages/common/nuclei.md
8542d3f 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin
Copy link
Member Author

Thanks for your quality comments and change suggestions @vitorhcl

gutjuri
gutjuri reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@gutjuri gutjuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have one minor suggestion.

pages/common/nuclei.md Outdated Show resolved Hide resolved
@fazlearefin @gutjuri
Update pages/common/nuclei.md
05be995 
Co-authored-by: Juri Dispan <juri.dispan@posteo.net>
kbdharun
kbdharun reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I have some suggestions for this page.

pages/common/nuclei.md Outdated Show resolved Hide resolved
pages/common/nuclei.md Outdated Show resolved Hide resolved
pages/common/nuclei.md Outdated Show resolved Hide resolved
fazlearefin and others added 3 commits February 14, 2024 18:12
@fazlearefin @kbdharun
Update pages/common/nuclei.md
5f6e381 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@fazlearefin @kbdharun
Update pages/common/nuclei.md
dd9bfc5 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@fazlearefin @kbdharun
Update pages/common/nuclei.md
6e6258e 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
kbdharun
kbdharun approved these changes Feb 14, 2024
View reviewed changes
pages/common/nuclei.md Outdated Show resolved Hide resolved
@fazlearefin @kbdharun
Update pages/common/nuclei.md
6ebce26 
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
@fazlearefin fazlearefin mentioned this pull request Feb 15, 2024
Merged
5 tasks
vitorhcl
vitorhcl approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the following suggestion

pages/common/nuclei.md Outdated Show resolved Hide resolved
@fazlearefin @vitorhcl
Update pages/common/nuclei.md
b5c5407 
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
@fazlearefin fazlearefin merged commit f1b8f46 into main Feb 15, 2024
8 checks passed
@fazlearefin fazlearefin deleted the feature/nuclei-vul-scanner branch February 15, 2024 16:24
@fazlearefin fazlearefin mentioned this pull request Feb 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gutjuri gutjuri gutjuri left review comments

@kbdharun kbdharun kbdharun approved these changes

@Magrid0 Magrid0 Magrid0 approved these changes

@vitorhcl vitorhcl vitorhcl approved these changes

Assignees
No one assigned
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fazlearefin @gutjuri @kbdharun @Magrid0 @vitorhcl