Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplehttpserver: add page #12261

Merged
merged 11 commits into from
Feb 15, 2024
Merged

simplehttpserver: add page #12261

merged 11 commits into from
Feb 15, 2024

Conversation

fazlearefin
Copy link
Member

@fazlearefin fazlearefin commented Feb 14, 2024

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known):

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Feb 14, 2024
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I have some suggestions

pages/common/simplehttpserver.md Outdated Show resolved Hide resolved
pages/common/simplehttpserver.md Outdated Show resolved Hide resolved
pages/common/simplehttpserver.md Outdated Show resolved Hide resolved
pages/common/simplehttpserver.md Outdated Show resolved Hide resolved
pages/common/simplehttpserver.md Outdated Show resolved Hide resolved
fazlearefin and others added 5 commits February 15, 2024 04:01
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
pages/common/simplehttpserver.md Outdated Show resolved Hide resolved
pages/common/simplehttpserver.md Outdated Show resolved Hide resolved
pages/common/simplehttpserver.md Outdated Show resolved Hide resolved
pages/common/simplehttpserver.md Outdated Show resolved Hide resolved
Copy link
Member

@vitorhcl vitorhcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after @kbdharun's and my suggestions

pages/common/simplehttpserver.md Outdated Show resolved Hide resolved
Copy link
Member

@acuteenvy acuteenvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of mnemonics here if the program does not support short options?

pages/common/simplehttpserver.md Outdated Show resolved Hide resolved
fazlearefin and others added 5 commits February 15, 2024 13:58
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
@fazlearefin fazlearefin merged commit 190c1a3 into main Feb 15, 2024
8 checks passed
@fazlearefin fazlearefin deleted the feature/simplehttpserver branch February 15, 2024 03:08
@kbdharun
Copy link
Member

@fazlearefin Just a minor suggestion, in future don't merge PRs if there is a conversation going on (i.e. acuteenvy's suggestion to remove mnemonics). I will update this page in a new PR.

@fazlearefin
Copy link
Member Author

fazlearefin commented Feb 15, 2024

@kbdharun Sure. In that case #12252 needs an update as well with the mnemonics.

@kbdharun
Copy link
Member

kbdharun commented Feb 15, 2024

@kbdharun Sure. In that case #12252 needs an update as well with the mnemonics.

Just now checked it, that page is fine. See https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md#short-option-mnemonics for more information.

sebastiaanspeck pushed a commit to sebastiaanspeck/tldr that referenced this pull request Feb 15, 2024
* simplehttpserver: add page

* Update pages/common/simplehttpserver.md

Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>

* Update pages/common/simplehttpserver.md

Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>

* Update pages/common/simplehttpserver.md

Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>

* Update pages/common/simplehttpserver.md

Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>

* Update pages/common/simplehttpserver.md

Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>

* Update pages/common/simplehttpserver.md

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* Update pages/common/simplehttpserver.md

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* Update pages/common/simplehttpserver.md

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* Update pages/common/simplehttpserver.md

Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>

* Update pages/common/simplehttpserver.md

Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>

---------

Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
@fazlearefin fazlearefin mentioned this pull request Mar 8, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants