-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplehttpserver: add page #12261
simplehttpserver: add page #12261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I have some suggestions
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after @kbdharun's and my suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the point of mnemonics here if the program does not support short options?
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
@fazlearefin Just a minor suggestion, in future don't merge PRs if there is a conversation going on (i.e. acuteenvy's suggestion to remove mnemonics). I will update this page in a new PR. |
Just now checked it, that page is fine. See https://github.com/tldr-pages/tldr/blob/main/contributing-guides/style-guide.md#short-option-mnemonics for more information. |
* simplehttpserver: add page * Update pages/common/simplehttpserver.md Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com> * Update pages/common/simplehttpserver.md Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com> * Update pages/common/simplehttpserver.md Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com> * Update pages/common/simplehttpserver.md Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com> * Update pages/common/simplehttpserver.md Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com> * Update pages/common/simplehttpserver.md Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com> * Update pages/common/simplehttpserver.md Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com> * Update pages/common/simplehttpserver.md Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com> * Update pages/common/simplehttpserver.md Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com> * Update pages/common/simplehttpserver.md Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com> --------- Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com> Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com> Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
common
,linux
,osx
,windows
,sunos
,android
, etc.