-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fitstopnm, pamcut, pamdeinterlace, pamdice, pammixinterlace, pamtofits, pamundice, pnmtofits: add pages #12296
Conversation
…s, pamundice, pnmtofits: add pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I will review it carefully when I have the time, but I already have some suggestions
pages/common/pamundice.md
Outdated
|
||
- Combine the images whose names match the `printf`-style filename expression. Assume a grid of size `x_value` times `y_value`: | ||
|
||
`pamundice {{filename_%1d_%1a.ppm}} -across {{x_value}} -down {{y_value}} > {{path/to/output.ppm}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it doesn't support a path as an argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can address the filename vs path/to/file issue on another PR
|
||
- Assume that the tiles overlap horizontally and vertically by the specified amount: | ||
|
||
`pamundice {{filename_%1d_%1a.ppm}} -across {{x_value}} -down {{y_value}} -hoverlap {{value}} -voverlap {{value}} > {{path/to/output.ppm}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it doesn't support a path as an argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, i'm not entirely sure whether or not it does. It is not included in the Netpbm bundle on my computer, so I can't test.
BTW, excellent work on this "Let's document", it's good to know that this PR will close it. |
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked that this one takes a path argument.
Thanks. However, since the Netpbm version installed on my system is not the latest version, #10887 does not contain all commands in Netpbm :( I think I'll will open another issue for the new commands. The old one has grown quite large. |
Yeah I just saw there's much more commands 😅 you can use the Arch Linux package list to easily make a new "Let's document" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks for your contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! I have some suggestions
pages/common/pamundice.md
Outdated
|
||
- Combine the images whose names match the `printf`-style filename expression. Assume a grid of size `x_value` times `y_value`: | ||
|
||
`pamundice {{filename_%1d_%1a.ppm}} -across {{x_value}} -down {{y_value}} > {{path/to/output.ppm}}` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can address the filename vs path/to/file issue on another PR
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
Co-authored-by: Vitor Henrique <87824454+vitorhcl@users.noreply.github.com>
common
,linux
,osx
,windows
,sunos
,android
, etc.