-
Notifications
You must be signed in to change notification settings - Fork 2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
auto-it/typescript fails the release, patch the problem away while mo…
…ds are asleep (#2498) Currently main can't be released: https://github.com/tldraw/tldraw/actions/runs/7557438453/job/20576664393 The issue was bisected down to 2904486 and can be "fixed" by forcing TypeScript to the previous resolution (5.3.3->4.9.5). It looks like Auto runs node-ts on everything, and Typescript picks up a module/moduleResolution mismatch somewhere. It is likely that the mismatch is not in our code, since blind replacement of all instances of `"moduleResolution"` to `"NodeNext"` in the project doesn't help. It is likely that the relevant TypeScript change is this one: https://www.typescriptlang.org/docs/handbook/modules/reference.html#the-moduleresolution-compiler-option Further investigation is pending, but this PR should fix the release process. ### Change Type - [x] `internal` — Any other changes that don't affect the published package
- Loading branch information
Showing
3 changed files
with
70 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/dist/auto.js b/dist/auto.js | ||
index f85465f2bf6968bbc2a8c9d66eaa181a6a3cdabd..8723c86f2be2c41a7638fc842964093808c55cc4 100644 | ||
--- a/dist/auto.js | ||
+++ b/dist/auto.js | ||
@@ -34,7 +34,7 @@ const is_binary_1 = tslib_1.__importDefault(require("./utils/is-binary")); | ||
const git_reset_1 = require("./utils/git-reset"); | ||
try { | ||
if (require.resolve("typescript")) { | ||
- require("ts-node/register/transpile-only"); | ||
+ // require("ts-node/register/transpile-only"); | ||
} | ||
} | ||
catch (error) { |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64b8f2e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully deployed to the following URLs:
examples – ./
preview.tldraw.com
examples.tldraw.com
examples-git-main-tldraw.vercel.app
examples-tldraw.vercel.app
bublic.tldraw.com
examples-omega.vercel.app