auto-it/typescript fails the release, patch the problem away while mods are asleep #2498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ds300
approved these changes
Jan 18, 2024
|
@si14 added an upstream PR for this intuit/auto#2420 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently main can't be released: https://github.com/tldraw/tldraw/actions/runs/7557438453/job/20576664393
The issue was bisected down to 2904486 and can be "fixed" by forcing TypeScript to the previous resolution (5.3.3->4.9.5).
It looks like Auto runs node-ts on everything, and Typescript picks up a module/moduleResolution mismatch somewhere. It is likely that the mismatch is not in our code, since blind replacement of all instances of
"moduleResolution"to"NodeNext"in the project doesn't help.It is likely that the relevant TypeScript change is this one: https://www.typescriptlang.org/docs/handbook/modules/reference.html#the-moduleresolution-compiler-option
Further investigation is pending, but this PR should fix the release process.
Change Type
internal— Any other changes that don't affect the published package