[Bug]: Cropping preview sometimes does not work until you change the crop #2284
Labels
bug
Something isn't working
Comments
8 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Dec 6, 2023
Fixes an issue where the editor reference in shape utils was not up to date with the editor returned from `useEditor`. Actually, the whole util was the incorrect one and was holding a reference to the previous instantiation of the editor. This only occurred in dev mode, but could also happen in other cases where editor is created multiple times. To see the kinds of issues this causes in dev mode you can do the following: 1. Create an image, crop it. 2. Refresh the page. 3. Select the image, then double click it to enter crop mode. 4. You will not see the cropped area of the image. You need to change the crop slightly and then it suddenly appears. This is because this changes props, which reruns the memoized function. Fixes #2284 ### Change Type - [x] `patch` — Bug fix - [ ] `minor` — New feature - [ ] `major` — Breaking change - [ ] `dependencies` — Changes to package dependencies[^1] - [ ] `documentation` — Changes to the documentation only[^2] - [ ] `tests` — Changes to any test code only[^2] - [ ] `internal` — Any other changes that don't affect the published package[^2] - [ ] I don't know [^1]: publishes a `patch` release, for devDependencies use `internal` [^2]: will not publish a new version ### Release Notes - Fix an issue where the shape utils could have a stale reference to the editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like this only happens locally and it might be due to strict mode?
What happened?
For me it happens every time when:
As soon as I interact with the image it starts to show the cropped area correctly. Happens in all browsers.
How can we reproduce the bug?
CleanShot.2023-12-05.at.09.42.12.mp4
What browsers are you seeing the problem on?
Firefox, Chrome, Safari
Contact Details
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: