Fix an issue with a stale editor reference in shape utils #2295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the editor reference in shape utils was not up to date with the editor returned from
useEditor
. Actually, the whole util was the incorrect one and was holding a reference to the previous instantiation of the editor.This only occurred in dev mode, but could also happen in other cases where editor is created multiple times. To see the kinds of issues this causes in dev mode you can do the following:
Fixes #2284
Change Type
patch
— Bug fixminor
— New featuremajor
— Breaking changedependencies
— Changes to package dependencies1documentation
— Changes to the documentation only2tests
— Changes to any test code only2internal
— Any other changes that don't affect the published package2Release Notes
Footnotes
publishes a
patch
release, for devDependencies useinternal
↩will not publish a new version ↩ ↩2 ↩3