Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dragging after pressing the middle mouse button in Safari browser, the gesture does not automatically recover after releasing the middle button. #3013

Closed
1 task done
wisinfun opened this issue Mar 1, 2024 · 2 comments · Fixed by #3792
Labels
bug Something isn't working

Comments

@wisinfun
Copy link

wisinfun commented Mar 1, 2024

What happened?

Dragging after pressing the middle mouse button in Safari browser, the gesture does not automatically recover after releasing the middle button.

How can we reproduce the bug?

Safari 17.3.1
https://www.tldraw.com

Dragging after pressing the middle mouse button in Safari browser, the gesture does not automatically recover after releasing the middle button.

What browsers are you seeing the problem on?

Safari

Contact Details

wisinfun@qq.com

Code of Conduct

  • I agree to follow this project's Code of Conduct
@wisinfun wisinfun added the bug Something isn't working label Mar 1, 2024
github-merge-queue bot pushed a commit that referenced this issue May 21, 2024
closes #3013 
closes #3733

This fixes a bug wherein the `inputs.isPanning` state was not being
unset correctly after a middle-click-to-pan gesture with a mouse.

### Change Type

<!-- ❗ Please select a 'Scope' label ❗️ -->

- [x] `sdk` — Changes the tldraw SDK
- [ ] `dotcom` — Changes the tldraw.com web app
- [ ] `docs` — Changes to the documentation, examples, or templates.
- [ ] `vs code` — Changes to the vscode plugin
- [ ] `internal` — Does not affect user-facing stuff

<!-- ❗ Please select a 'Type' label ❗️ -->

- [x] `bugfix` — Bug fix
- [ ] `feature` — New feature
- [ ] `improvement` — Improving existing features
- [ ] `chore` — Updating dependencies, other boring stuff
- [ ] `galaxy brain` — Architectural changes
- [ ] `tests` — Changes to any test code
- [ ] `tools` — Changes to infrastructure, CI, internal scripts,
debugging tools, etc.
- [ ] `dunno` — I don't know


### Test Plan

1. Add a step-by-step description of how to test your PR here.
2.

- [ ] Unit Tests
- [ ] End to end tests

### Release Notes

- Add a brief release note for your PR here.
@ds300
Copy link
Collaborator

ds300 commented May 21, 2024

Thanks for the report! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants