Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Cleanup input state after middle-click-to-pan #3792

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

ds300
Copy link
Collaborator

@ds300 ds300 commented May 21, 2024

closes #3013
closes #3733

This fixes a bug wherein the inputs.isPanning state was not being unset correctly after a middle-click-to-pan gesture with a mouse.

Change Type

  • sdk — Changes the tldraw SDK
  • dotcom — Changes the tldraw.com web app
  • docs — Changes to the documentation, examples, or templates.
  • vs code — Changes to the vscode plugin
  • internal — Does not affect user-facing stuff
  • bugfix — Bug fix
  • feature — New feature
  • improvement — Improving existing features
  • chore — Updating dependencies, other boring stuff
  • galaxy brain — Architectural changes
  • tests — Changes to any test code
  • tools — Changes to infrastructure, CI, internal scripts, debugging tools, etc.
  • dunno — I don't know

Test Plan

  1. Add a step-by-step description of how to test your PR here.
  • Unit Tests
  • End to end tests

Release Notes

  • Add a brief release note for your PR here.

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview May 21, 2024 8:43am
1 Ignored Deployment
Name Status Preview Updated (UTC)
tldraw-docs ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 8:43am

@huppy-bot huppy-bot bot added bugfix Bug fix sdk Affects the tldraw sdk labels May 21, 2024
@ds300 ds300 enabled auto-merge May 21, 2024 08:40
@ds300 ds300 added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 1452978 May 21, 2024
12 checks passed
@ds300 ds300 deleted the david/fix-pan-stop branch May 21, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fix sdk Affects the tldraw sdk
Projects
None yet
1 participant