Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stickies: try out auto-sizing text instead of auto-sizing the shape #3142

Closed
wants to merge 1 commit into from

Conversation

mimecuvalo
Copy link
Member

@mimecuvalo mimecuvalo commented Mar 13, 2024

I don't think we should go this route after playing with it for a while, but maybe combined with @Taha-Hassan-Git 's exploration on "see more" this could play more nicely when it gets too small. Btw, @Taha-Hassan-Git if you wanna base your work off of this PR, it might be interesting, but it's up to you!

Kapture.2024-03-22.at.11.54.00.mp4

Change Type

  • sdk — Changes the tldraw SDK
  • dotcom — Changes the tldraw.com web app
  • docs — Changes to the documentation, examples, or templates.
  • vs code — Changes to the vscode plugin
  • internal — Does not affect user-facing stuff
  • bugfix — Bug fix
  • feature — New feature
  • improvement — Improving existing features
  • chore — Updating dependencies, other boring stuff
  • galaxy brain — Architectural changes
  • tests — Changes to any test code
  • tools — Changes to infrastructure, CI, internal scripts, debugging tools, etc.
  • dunno — I don't know

Test Plan

  1. Add a step-by-step description of how to test your PR here.
  • Unit Tests
  • End to end tests

Release Notes

  • Stickies: auto-size font on stickies when reaching the limits of the height.

@huppy-bot huppy-bot bot added improvement Product improvement sdk Affects the tldraw sdk labels Mar 13, 2024
Copy link

linear bot commented Mar 13, 2024

TLD-2269 Auto size font

Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview Mar 13, 2024 3:25pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
tldraw-docs ⬜️ Ignored (Inspect) Visit Preview Mar 13, 2024 3:25pm

@Taha-Hassan-Git
Copy link
Contributor

This is cool! What didn't you like about it? I'll take a look at the implementation and see if it'll help me get there faster.

@mimecuvalo
Copy link
Member Author

This is cool! What didn't you like about it? I'll take a look at the implementation and see if it'll help me get there faster.

I think I don't like that it doesn't have a lower bound of sizing. It feels like a cop-out that it should just get smaller infinitely.
Another UI affordance like the 'see more' could help alleviate this though.

@mimecuvalo mimecuvalo closed this Mar 27, 2024
@steveruizok steveruizok mentioned this pull request Apr 1, 2024
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Product improvement sdk Affects the tldraw sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants