Stickies: release candidate #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
This PR adds a new Sticky icon: <img width="548" alt="image" src="https://github.com/tldraw/tldraw/assets/23072548/cd72e23d-b2c0-427f-a3dc-54cef09f0bda"> ### Change Type - [x] `improvement` --------- Co-authored-by: Steve Ruiz <steveruizok@gmail.com>
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
This PR: - adds slightly randomized transformed shadows to sticky notes - removes the border from sticky notes - tightens up the border radius for notes <img width="1363" alt="image" src="https://github.com/tldraw/tldraw/assets/23072548/6ffc8c76-82ef-45af-9f04-6fb3b8af32db"> <img width="1588" alt="image" src="https://github.com/tldraw/tldraw/assets/23072548/c2172ed4-748d-4957-972e-f80be62685cd"> ### Change Type <!-- ❗ Please select a 'Scope' label ❗️ --> - [x] `sdk` — Changes the tldraw SDK - [ ] `dotcom` — Changes the tldraw.com web app - [ ] `docs` — Changes to the documentation, examples, or templates. - [ ] `vs code` — Changes to the vscode plugin - [ ] `internal` — Does not affect user-facing stuff <!-- ❗ Please select a 'Type' label ❗️ --> - [ ] `bugfix` — Bug fix - [ ] `feature` — New feature - [x] `improvement` — Improving existing features - [ ] `chore` — Updating dependencies, other boring stuff - [ ] `galaxy brain` — Architectural changes - [ ] `tests` — Changes to any test code - [ ] `tools` — Changes to infrastructure, CI, internal scripts, debugging tools, etc. - [ ] `dunno` — I don't know ### Release Notes - Adds sticky note shadows
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
mimecuvalo
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
The gif shows it all. This is a further iteration on https://github.com/tldraw/tldraw/pull/3142/files This doesn't mean that we necessarily want to keep the `growY` property. It just shows that we can sometimes rely on the CSS `overflow-wrap` property and sometimes we can try to actively avoid where it makes sense. I put a lower size limit of 12 but I think I'm open to having a higher one, maybe 14? Hard to say. - [x] SVG export - [x] Check previous text wrapping PRs for a text torture file - [x] Tests https://github.com/tldraw/tldraw/assets/469604/352b2721-b2e7-40ec-bb19-46e0bd607e1c ### Change Type <!-- ❗ Please select a 'Scope' label ❗️ --> - [x] `sdk` — Changes the tldraw SDK - [ ] `dotcom` — Changes the tldraw.com web app - [ ] `docs` — Changes to the documentation, examples, or templates. - [ ] `vs code` — Changes to the vscode plugin - [ ] `internal` — Does not affect user-facing stuff <!-- ❗ Please select a 'Type' label ❗️ --> - [ ] `bugfix` — Bug fix - [ ] `feature` — New feature - [x] `improvement` — Improving existing features - [ ] `chore` — Updating dependencies, other boring stuff - [ ] `galaxy brain` — Architectural changes - [ ] `tests` — Changes to any test code - [ ] `tools` — Changes to infrastructure, CI, internal scripts, debugging tools, etc. - [ ] `dunno` — I don't know ### Test Plan 1. Add a step-by-step description of how to test your PR here. 2. - [ ] Unit Tests - [ ] End to end tests ### Release Notes - Add a brief release note for your PR here.
mimecuvalo
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
Breakout from #2953 Auto-edit a shape upon keystroke. Related to this change is that we shouldn't do the selection of all text when editing (and it would conflict currently with this behavior, or at least we'd have to special case). In any case, I would argue that it's odd and doesn't feel like the right move — this PR updates it so that it puts the cursor at the end of the text which to me feels better or more expected. ### Change Type - [x] `patch` — Bug fix ### Release Notes - Sticky note: auto-edit on keystroke.
mimecuvalo
had a problem deploying
to
deploy-staging
GitHub Actions
Failure
mimecuvalo
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
This reverts commit b211874.
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
steveruizok
had a problem deploying
to
deploy-staging
GitHub Actions
Failure
steveruizok
temporarily deployed
to
deploy-staging
GitHub Actions
Inactive
|
(fyi i brought back the stickies-rc branch - i needed to bisect on some stuff) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the target for the stickies PRs that are moving forward. It should collect changes.
Change Type
sdk— Changes the tldraw SDKfeature— New featureTest Plan
Todo: fold in test plans for child PRs
Unit tests:
Release Notes