Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolbar: fix missing title attributes #3244

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Conversation

mimecuvalo
Copy link
Member

The title attribute is currently missing in production. It was using title when it should have been using titleStr
This also nixes the title attribute which is used just twice in the codebase — probably not necessary to have a different title/label but lemme know if you disagree.

Adds this behavior back in:
Screenshot 2024-03-22 at 18 15 42

Change Type

  • sdk — Changes the tldraw SDK
  • dotcom — Changes the tldraw.com web app
  • docs — Changes to the documentation, examples, or templates.
  • vs code — Changes to the vscode plugin
  • internal — Does not affect user-facing stuff
  • bugfix — Bug fix
  • feature — New feature
  • improvement — Improving existing features
  • chore — Updating dependencies, other boring stuff
  • galaxy brain — Architectural changes
  • tests — Changes to any test code
  • tools — Changes to infrastructure, CI, internal scripts, debugging tools, etc.
  • dunno — I don't know

Release Notes

  • Fix title's being missing on toolbar items.

@huppy-bot huppy-bot bot added bugfix Bug fix sdk Affects the tldraw sdk labels Mar 22, 2024
Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
examples ✅ Ready (Inspect) Visit Preview Mar 22, 2024 7:59pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
tldraw-docs ⬜️ Ignored (Inspect) Visit Preview Mar 22, 2024 7:59pm

@steveruizok
Copy link
Collaborator

Nice one. I also took the title off of the TLUiActionItem, as that will no longer be used. I think at one point I differentiated between the title and the label but I can't recall why; and anyway, we aren't using the title property of the action item anywhere in the codebase.

@steveruizok steveruizok added this pull request to the merge queue Mar 24, 2024
Merged via the queue into main with commit a8477d0 Mar 24, 2024
10 checks passed
@steveruizok steveruizok deleted the mime/toolbar-title-fix branch March 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fix sdk Affects the tldraw sdk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants