Eager realization #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this implementation uses the idea from #4 where load the raw data, lazily apply transformations and then eagerly realize the final version to reduce the access-time penalty. It might be possible to refactor this code a bit further to dispatch on the IFD layout so that I can avoid a lot of these if/else statements and off load them to compile time.
seems like there was a gap in coverage and this got missed
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 79.78% 81.66% +1.87%
==========================================
Files 9 9
Lines 282 289 +7
==========================================
+ Hits 225 236 +11
+ Misses 57 53 -4
Continue to review full report at Codecov.
|
tlnagy
added a commit
that referenced
this pull request
Jan 8, 2021
This is really a follow-up to #10, now I dispatch differently depending on whether a TIFF is a single page or not. Additionally, data is read directly in the final type container, getting rid of most lazy transformations yielding substantial speed improvements of ~10X.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4. Now,
TIFF.jlwill fully realize the lazily transformed images before returning them so access times are essentially the same as ImageMagick while preserving a lot of the speed/memory advantages:Load benchmarking: This PR vs ImageMagick.jl v1.1.6
It looks like
TIFF.jlbeats ImageMagick both in load time and memory usage on every test except involving Packbits compression (capitol.tif) andbali.tifwhereTIFF.jlfails because of #8.Access times
But now access times are much improved:
Limitations
There are still some limitations with images with many planes since I lazily transform each plane and then realize them each round. These lazy transforms currently rely on if/else statements, which is not great. I need to explore offloading this work to compile time and dispatch on the TIFF structure.