Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up keying material extractors #105

Closed
tomato42 opened this issue Jun 23, 2016 · 0 comments · Fixed by #398
Closed

clean up keying material extractors #105

tomato42 opened this issue Jun 23, 2016 · 0 comments · Fixed by #398
Assignees
@inikolcev
Labels
good first issue relatively simple changes, good for first time contributors help wanted
Milestone
v0.8.0

Comments

@tomato42
Copy link
Member

calcExtendedMasterSecret(), calcMasterSecret(), calcFinished(), _calcKeyBlock(), all use essentially the same code, with just different labels. We should move it to single place
@tomato42 tomato42 added help wanted good first issue relatively simple changes, good for first time contributors labels Jun 23, 2016
@tomato42 tomato42 added this to the someday/future milestone Jun 23, 2016
@tomato42 tomato42 mentioned this issue Jun 23, 2016
Merged
@tomato42 tomato42 modified the milestones: v0.8.0, someday/future Jul 21, 2017
@inikolcev inikolcev mentioned this issue Mar 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inikolcev inikolcev

Labels
good first issue relatively simple changes, good for first time contributors help wanted
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Move keying material extractors to one place inikolcev/tlslite-ng
2 participants
@tomato42 @inikolcev