Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading config values from CLI for notary-server #604

Closed
yuroitaki opened this issue Sep 25, 2024 · 2 comments
Closed

Support reading config values from CLI for notary-server #604

yuroitaki opened this issue Sep 25, 2024 · 2 comments
Labels
good first issue Good for newcomers notary server Improvements or problems in the notary server reference implementation

Comments

@yuroitaki
Copy link
Member

Support reading some of the frequently used/changed values in the config file from CLI, e.g.

  • port
  • tls.enabled
  • logging.level

This can be done either via CLI parser lib like StructOpt or environment variable. Then something like config-rs can be used to combine these configs from different sources.
@yuroitaki yuroitaki added good first issue Good for newcomers notary server Improvements or problems in the notary server reference implementation labels Sep 25, 2024
@anthonykimani anthonykimani mentioned this issue Sep 25, 2024
Merged
@yuroitaki yuroitaki assigned yuroitaki and unassigned yuroitaki Oct 4, 2024
@maceip
Copy link
Collaborator

maceip commented Oct 10, 2024

🚀

@yuroitaki
Copy link
Member Author

Addressed by #605.

@heeckhau heeckhau mentioned this issue Oct 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers notary server Improvements or problems in the notary server reference implementation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maceip @yuroitaki