Targeting sl50 wrong

[kroniak]

@tmenier
I have found bug in package Flurl.Http. It is not referencing with last net core versions.

You are targeting

<group targetFramework="portable-net45+sl50+win+wpa81+wp80">
                <dependency id="Microsoft.Bcl.Async" version="1.0.168" />
                <dependency id="Microsoft.Net.Http" version="2.2.22" />
                <dependency id="PCLStorage" version="0.9.6" />
                <dependency id="Newtonsoft.Json" version="6.0.3" />
                <dependency id="Flurl" version="1.1.0-pre" />
            </group>

But Newtonsoft.Json "6.0.3" does not support sl50.
Any lib whom targets Flurl.Http cannot resolve this target, only portable without sl50 works.

[kroniak]

There are way to avoid it, it is targeting sl50 separate

"frameworks": {
    "portable-net45+win+wpa81+wp80": { },
    "portable-net45+sl50": { }
  }

But it is a wrong way.

[tmenier]

I'm comfortable with dropping sl5 support altogether. It's caused issues in the past, and my response was to simply remove it from the list of officially supported targets (which I should update again for .NET Core by the way).

Just curious, regarding your suggested fix, why is that the "wrong way"? I'd be inclined to consider it if it makes all target platforms happy. But if there's good reason to avoid it, I'm fine with just dropping sl50.

[tmenier]

Related: #27

[kroniak]

It works, but it is "dog-nail". We call this case that in RU.
In theory package must be included and works in other libraries without changing targets.

Decision about remove target sl50 from PCL is fully on your side.

[tmenier]

Just curious, how do you know that Json.NET does not support sl50? I'm almost ready to say that SL 5 and Windows Phone SL 8.1 are out, but I'd hate to alienate anyone who might be targeting those. Would simply upgrading Json.NET to a newer versions help? Again, I'm not sure how to determine that.

[tmenier]

I announced on Twitter that I'll be dropping SL support altogether and haven't heard a word, so that'll be happening soon. I did some major re-writing of pieces of the core URL parser and there are a few breaking changes, so I'll be up'ing the major version of Flurl to 2.0.

[kroniak]

@tmenier I am wrong about sl5 dependency JSON net. It contains SL5 in portable version with net40. And there are no way to target dnx and sl5 together with net45.

[tmenier]

No worries. I think we're fine without Silverlight. If I'm wrong, we can look at adding it back.