Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends from System.URI, instead of System.String #62

Closed
thiagolunardi opened this issue Feb 24, 2016 · 3 comments
Closed

Extends from System.URI, instead of System.String #62

thiagolunardi opened this issue Feb 24, 2016 · 3 comments

Comments

@thiagolunardi
Copy link

It is really awesome what Flurl component can do.
But, to me, extend from System.String is out of context.

I understand that, when you extend from an object, this extension still been the same context of the extended object.

With that in mind, I usually do request agains URI routes, instead of whatever text string.

If you OK, I can do a pull request with this behavior.
Will be my pleasure do contribute.

@tmenier
Copy link
Owner

tmenier commented Mar 8, 2016

Are you suggesting creating extension methods off System.Uri instead of System.String? Or in addition to those?

@thiagolunardi
Copy link
Author

Yes, exactly.

@tmenier
Copy link
Owner

tmenier commented Mar 8, 2016

Please feel free to add your own extension methods to support this, but I won't add a breaking change of this magnitude to the core. Starting with a string minimizes noise and that's the main goal of the library. Thanks for the suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants