Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long spreadsheet writing operations can turn into an unhandled exception. #8

Open
tmilar opened this issue Mar 3, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@tmilar
Copy link
Owner

tmilar commented Mar 3, 2018

The current spreadsheet library doesn't handle a rare scenario when the spreadsheet given locks are lost.

To reproduce, call /order?store=true endpoint (with no dates limiter) to get a large operations writing request, then wait for this case to hit.

Also, the same library not only doesn't handle this error, but also uses some weird setTimeout callbacks in it's implementation, therefore, using this after promisifying doesn't allow to handle this exception which bubbles to the event loop itself and breaks the application.
.
I'll provide logs/screenshots/more references later.

@fmiras fmiras added the bug Something isn't working label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants