Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logic to handle Github Action Workflow dependencies on releases #23

Closed
phenixblue opened this issue May 7, 2020 · 2 comments · Fixed by #29
Closed

Add logic to handle Github Action Workflow dependencies on releases #23

phenixblue opened this issue May 7, 2020 · 2 comments · Fixed by #29
Assignees
@Freakin
Labels
ci enhancement New feature or request gh-actions

Comments

@phenixblue
Copy link
Contributor

What would you like to be added:

Add logic to handle Github Action Workflow dependencies on releases

Why is this needed:

Currently the release flow executes e2e tests prior to the new container image build because the same flow is used for PR/push to master. Need to make sure image build happens before e2e tests for release prep (push to master). This may require pre-release image builds or refactoring the Github Action workflows overall.
@phenixblue phenixblue added enhancement New feature or request gh-actions ci labels May 7, 2020
@Freakin
Copy link
Contributor

Freakin commented May 7, 2020

👀

@phenixblue
Copy link
Contributor Author

I think I have a working solution for this.

  • Build images based on current commit (PR or Push to master), but don't push to DockerHub
  • Modify version in Makefile to reference new image
  • Modify image pull policy in deployment to ifNotPresent
  • Update single-manifest
  • Build KinD cluster
  • Load new images directly into kind nodes (kind load docker-image)
  • Install MagTape
  • Run e2e tests

@phenixblue phenixblue mentioned this issue Jul 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Freakin Freakin

Labels
ci enhancement New feature or request gh-actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add image build for e2e checks phenixblue/magtape
2 participants
@Freakin @phenixblue