Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache bcsymbolmap files #100

Closed
HKisd opened this issue Aug 17, 2017 · 7 comments
Closed

Cache bcsymbolmap files #100

HKisd opened this issue Aug 17, 2017 · 7 comments

Comments

@HKisd
Copy link

HKisd commented Aug 17, 2017

Enhancement Suggestion

Cache bcsymbolmap files

Steps which explain the enhancement

  1. Upload should upload bcsymbolmap files of framework
  2. Download should download bcsymbolmap files framework

Current and suggested behavior

Currently bcsymbolmap files seem to be ignored by Rome
There should be a zip archive also for bcsymbolmap files

Carthage archive command makes a zip file which contains also bcsymbolmap files, so that might be useful reference:

$ carthage archive Alamofire
*** Found Carthage/Build/iOS/Alamofire.framework
*** Found Carthage/Build/iOS/Alamofire.framework.dSYM
*** Found Carthage/Build/iOS/7246C4C8-54CB-36B4-814F-E6E8B595EA74.bcsymbolmap
*** Found Carthage/Build/iOS/0F93FE26-5586-3A7C-8449-2DB18861AF00.bcsymbolmap
*** Found Carthage/Build/iOS/17132633-DF81-32A0-B7FE-BB4101B1C246.bcsymbolmap
*** Found Carthage/Build/iOS/A48FAE2B-3B09-3F27-A4FB-BE81C0FFE75B.bcsymbolmap
*** Created Alamofire.framework.zip

Why would the enhancement be useful to most users

bcsymbolmap is required for uploading bitcode containing apps to App Store

Rome version: 0.12.0.31
OS and version: macOS 10.12.6

@tmspzz
Copy link
Owner

tmspzz commented Aug 17, 2017

I see. Any idea how the bcsymbolmap is paired to the framework?

Ok, found out:

/usr/bin/xcrun dwarfdump --uuid <path-to-dsym>

@HKisd
Copy link
Author

HKisd commented Aug 17, 2017

Carthage uses this command to find the UUIDs for bcsymbolmap files:

/usr/bin/xcrun dwarfdump --uuid Alamofire.framework/Alamofire

@tmspzz
Copy link
Owner

tmspzz commented Aug 20, 2017

You can follow the development here: #101

@tmspzz
Copy link
Owner

tmspzz commented Sep 4, 2017

@HKisd please try https://github.com/blender/Rome/releases/tag/v0.13.0.32

This one actually took me some time to do.

If no bugs are reported I will promote it to a full release. Please let me know one you have tried.

@tmspzz
Copy link
Owner

tmspzz commented Sep 11, 2017

@HKisd did you have the chance to try it out?

@tmspzz
Copy link
Owner

tmspzz commented Sep 25, 2017

@HKisd any feedback? I'll make a full release in the next few days :)

@tmspzz
Copy link
Owner

tmspzz commented Oct 9, 2017

Done!

@tmspzz tmspzz closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants