Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmux 3 raises "invalid option" on an invalid option #281

Open
edouardklein opened this issue May 12, 2020 · 0 comments
Open

Tmux 3 raises "invalid option" on an invalid option #281

edouardklein opened this issue May 12, 2020 · 0 comments

Comments

@edouardklein
Copy link

Hi,

The following test:

def test_show_option_unknown(session):
    """Session.show_option raises UnknownOption for invalid option."""
    with pytest.raises(exc.UnknownOption):
        session.show_option('moooz')

in tests/test_session.py

fails because my version of tmux (3.1b) prints "invalid option: moooz" when given an invalid option.

I have no easy way to test whether tmux 2's behaviour was to throw an "unknown option" instead.

I don't know how you want to fix this. Shall we throw a UnknownOption to maintain backwards compatibility (is any one try...excepting for this specifically anyway ?) Shall we remove this test now that tmux has changed its ways ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant