Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tmux list-session parsing error by removing buffer_sample field from fetch_objs function #473

Closed
wants to merge 1 commit into from

Conversation

hongwen000
Copy link

@hongwen000 hongwen000 commented Jan 21, 2023

See issue #472 and issue #471

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2023

CLA assistant check
All committers have signed the CLA.

@tony
Copy link
Member

tony commented Jan 28, 2023

@hongwen000 Thank you for this contribution and the issues

There's another possibility where we can possibly keep the separator: We could change the separator from | to be something else, e.g. ␞ (see https://stackoverflow.com/a/29811033)

If you try env LIBTMUX_TMUX_FORMAT_SEPARATOR=␞, do you still get this problem? See also #475

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #473 (70c1783) into master (f7233c0) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #473      +/-   ##
==========================================
- Coverage   88.97%   88.91%   -0.07%     
==========================================
  Files          35       35              
  Lines        3484     3483       -1     
  Branches      484      484              
==========================================
- Hits         3100     3097       -3     
- Misses        276      278       +2     
  Partials      108      108              
Impacted Files Coverage Δ
src/libtmux/neo.py 97.64% <ø> (-0.02%) ⬇️
src/libtmux/server.py 65.75% <0.00%> (-0.92%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hongwen000
Copy link
Author

@tony Yes, this modification can also solve my problem. Changing the delimiter to a rare Unicode character is a nice idea. Although the this character existing in buffer_sample is theoretically possible, but it is almost unlikely. One "safe" solution is to call tmux list-session twice, to get buffer_sample and other fields separately. But this would increase additional complexity. In any case, I agree to change the delimiter to ␞ to solve this problem.

@tony
Copy link
Member

tony commented Jan 29, 2023

@hongwen000 I am going to release #475, come back, and see if it alleives the issue for you.

@hongwen000 hongwen000 closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants