FORMAT_SEPARATOR: Change to a character less likely to collide with buffers
#475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 35 35
Lines 3484 3484
Branches 484 484
=======================================
Hits 3098 3098
Misses 278 278
Partials 108 108
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tony
added a commit
that referenced
this pull request
Jan 29, 2023
tony
added a commit
to tmux-python/tmuxp
that referenced
this pull request
Jan 29, 2023
This adjusts the default separator for formats to be a pipe (somewhat common in the terminal) to a rare character - ␞. This will avoid crashes with various libtmux lookups. See also: - tmux-python/libtmux#475 - https://github.com/tmux-python/libtmux/releases/tag/v0.21.0
This was referenced Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #472 and issue #471 and PR #473 from @hongwen000