Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify pull request stance in Readme #10

Closed
af opened this issue Jun 4, 2015 · 5 comments
Closed

Clarify pull request stance in Readme #10

af opened this issue Jun 4, 2015 · 5 comments

Comments

@af
Copy link

af commented Jun 4, 2015

Hi,

Now that Github is the primary repo for tmux, my initial assumption was that pull requests would be the preferred way to submit patches. Since it is not, it would be nice to mention this in the readme.

Even though the Readme does explicitly say "Patches should be sent by email to
the mailing list at tmux-users@googlegroups.com.", I can't be the only person that would assume PRs would also be welcome. If you don't want to receive them, a mention of this in the Readme would probably save you some time.

@bruno-
Copy link

bruno- commented Jun 4, 2015

Also an idea: github has a nice feature where "guidelines for contributing" will be visibly prompted to a user before he/she opens a new issue or pull request as described in this blog post.

All that's needed it to create a CONTRIBUTING file in the project root. This could probably filter out some percentage of impulsive issue or PR openings and reduce the maintenance burden on the maintainers.

@nicm
Copy link
Member

nicm commented Jun 4, 2015

Let's see what happens before jumping to add to the documentation.

And no more documentation files, we have too many already. README or not at all.

-------- Original message --------
From: Bruno Sutic notifications@github.com
Date:04/06/2015 16:34 (GMT+00:00)
To: tmux/tmux tmux@noreply.github.com
Subject: Re: [tmux] Clarify pull request stance in Readme (#10)

Also an idea: github has a nice feature where "guidelines for contributing" will be visibly prompted to a user before he/she opens a new issue or pull request as described in this blog post.

All that's needed it to create a CONTRIBUTING file in the project root. This could probably filter out some percentage of impulsive issue or PR openings and reduce the maintenance burden on the maintainers.


Reply to this email directly or view it on GitHub.

@fatih
Copy link

fatih commented Jun 4, 2015

Checkout https://github.com/golang/go which doesn't not accept Pull Requests. They have a CONTRIBUTING.md and don't use Pull Requests at all.

@aleksandrs-ledovskis
Copy link

Another option - just edit project description. Check git/git for example

@lock
Copy link

lock bot commented Feb 17, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

5 participants