Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in RVineMatrixCheck #26

Closed
dtmueller opened this issue Nov 18, 2016 · 1 comment
Closed

Error in RVineMatrixCheck #26

dtmueller opened this issue Nov 18, 2016 · 1 comment

Comments

@dtmueller
Copy link

RVineMatrixCheck does not function properly if the matrix entered is not upper or lower triangular:

RVM
[,1] [,2] [,3] [,4] [,5] [,6] [,7] [,8] [,9] [,10]
[1,] 1 0 0 0 0 0 0 0 0 0
[2,] 0 9 0 0 0 0 0 5 0 0
[3,] 0 0 10 0 0 0 6 6 0 0
[4,] 0 0 0 6 0 8 7 3 0 0
[5,] 0 0 0 0 2 6 10 9 0 0
[6,] 0 0 0 3 8 8 8 8 0 0
[7,] 0 0 4 4 4 7 7 4 0 0
[8,] 0 3 7 8 3 5 3 5 0 0
[9,] 4 4 3 7 7 2 4 10 4 0
[10,] 3 5 5 5 2 4 2 2 3 3

RVineMatrixCheck(RVM)
Error in A2[i, j] <- iorder[A[i, j]] : replacement has length zero

I think a single check if an upper/lower triangular matrix is entered should fix the problem. Nevertheless, a sufficiently intelligent user would know that this matrix can not be an R-vine matrix.

@tnagler
Copy link
Owner

tnagler commented Nov 18, 2016

I added another error code (-4) for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants